βπ [RUMF-1296] use pointerup to trigger click actions #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/frustration-signals--track-pointerup
branch
from
baf6b21
to
e08c7af
Compare
Codecov Report
@@ Coverage Diff @@
## main #1958 +/- ##
==========================================
+ Coverage 93.34% 93.42% +0.08%
==========================================
Files 144 144
Lines 5482 5488 +6
Branches 1246 1251 +5
==========================================
+ Hits 5117 5127 +10
+ Misses 365 361 -4
π£ Weβre building smart automated test selection to slash your CI/CD build times. Learn more |
amortemousque
approved these changes
Jan 19, 2023
bcaudan
approved these changes
Jan 20, 2023
This commit will help implementing click actions triggered by pointerup behind a FF.
In 'listenActionEvents', we expect that a 'click' event is preceded by a single 'pointerdown' event. It turns out this is not always the case on multitouch devices. This issue would be amplified when listening to 'pointerup' events. Let's just focus on the 'primary' pointer events. This will ignore secondary touches until we implement proper support for them (if ever).
This slightly change the action beginning, but takes any activity produced by 'pointerup' 'mouseup' 'touchend' events into account. If those actions don't produce any activity, the action start is likely to be the same as before, since 'pointerup/mouseup/touchend' should be triggered very close to the 'click' event.
BenoitZugmeyer
force-pushed
the
benoit/frustration-signals--track-pointerup
branch
from
e08c7af
to
7e96c15
Compare
BenoitZugmeyer
force-pushed
the
benoit/frustration-signals--track-pointerup
branch
from
8394f84
to
3225f3d
Compare
This was referenced Jan 27, 2023
bcaudan
approved these changes
Jan 30, 2023
packages/rum-core/src/domain/rumEventsCollection/action/trackClickActions.ts
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
deleted the
benoit/frustration-signals--track-pointerup
branch
4 tasks
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
4 tasks
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 7, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 7, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 7, 2023
pm_trace_id: 13144861 feature_branch_pipeline_id: 13144861 source: to-staging * commit '6a98a9480c800aff92ce4c5d37270534623f7661': β remove now unneeded experimental flag from e2e tests β π₯ remove now unneeded clock mock in tests π©π enable fix #1979 π remove pointerup_delay info for #1958 π©π enable fix #1958 π©π enable fix #1968 π©π enable fix #1986
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 10, 2023
* π©π enable fix #1986 * π©π enable fix #1968 * π©π enable fix #1958 * π remove pointerup_delay info for #1958 * π©π enable fix #1979 * β π₯ remove now unneeded clock mock in tests * β remove now unneeded experimental flag from e2e tests * π rename `onStartEvent` to `onPointerUp` * π rename startEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket is part of an effort to improve dead clicks.
All three fixes are behind the
dead_click_fixesand will be released together after some dogfooding.Motivation
We observed that in some cases, click actions are flagged as "dead click" when the UI updates during "pointerup" or "mouseup" events (happening before the "click" event).
Changes
This PR fixes the issue by starting a "click action" on
pointerupinstead ofclickevents. This slightly changes the start of each action, but this change should be minimal when there is nopointerupormouseupevent listener.This is behind a feature flag as I want to assess the impact on org2 before enabling it.
This PR also improve the multitouch situation.
Testing
I have gone over the contributing documentation.